Skip to content

fix: prevent copy button overlapping E2B badge in template name cell#457

Merged
drankou merged 1 commit into
mainfrom
copy-button-badge-overlap
Jun 24, 2026
Merged

fix: prevent copy button overlapping E2B badge in template name cell#457
drankou merged 1 commit into
mainfrom
copy-button-badge-overlap

Conversation

@drankou

@drankou drankou commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The copy button in the templates list Name cell was absolutely positioned (absolute right-0), so it reserved no horizontal space and the in-flow E2B/+N badges slid underneath it whenever the name filled the cell (narrow Name column or default-template rows). This moves the button back into flow with ml-auto shrink-0 so it reserves its own space and the badges can no longer collide with it, while keeping relative z-10 so it stays clickable above the row's overlay navigation link.

Fixes EN-1115.

🤖 Generated with Claude Code

The copy button was absolutely positioned (right-0), reserving no space,
so the in-flow E2B/+N badges slid underneath it when the name filled the
cell. Move it back in flow with ml-auto so it reserves its own space.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@linear-code

linear-code Bot commented Jun 24, 2026

Copy link
Copy Markdown

EN-1115

@cla-bot cla-bot Bot added the cla-signed label Jun 24, 2026
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 24, 2026 3:05pm
web-tango Building Building Preview, Comment Jun 24, 2026 3:05pm

Request Review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@drankou drankou merged commit 26c3108 into main Jun 24, 2026
14 checks passed
@drankou drankou deleted the copy-button-badge-overlap branch June 24, 2026 15:18

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — minimal CSS-only swap from absolute to in-flow layout for the copy button.

Extended reasoning...

Overview

This PR modifies a single className on the copy button in the templates list Name cell (src/features/dashboard/templates/list/table-cells.tsx). It swaps absolute right-0 for relative ml-auto shrink-0, keeping z-10 so the button stays clickable above the row's overlay navigation link. The fix prevents the in-flow E2B/+N badges from sliding underneath the absolutely positioned button.

Security risks

None. This is a purely presentational Tailwind class change with no logic, data flow, auth, or input handling touched.

Level of scrutiny

Very low scrutiny is warranted — this is a one-line CSS tweak in a presentational component. The change is mechanical: absolute right-0 reserves no width, while ml-auto shrink-0 does, which directly explains why the badges no longer collide. The surrounding flex container (flex items-center gap-2) already supports ml-auto for right-alignment.

Other factors

The bug hunting system found no issues. Vercel preview deployments built successfully. The PR is well-described, scoped to a single file, and references a Linear ticket (EN-1115). No outstanding reviewer comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants